Finish adding OSGi support#8417
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8417 +/- ##
============================================
+ Coverage 90.99% 91.02% +0.03%
- Complexity 7814 7818 +4
============================================
Files 892 893 +1
Lines 23718 23719 +1
Branches 2364 2364
============================================
+ Hits 21582 21591 +9
+ Misses 1416 1408 -8
Partials 720 720 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… add unit test to ensure provides-capability always matchines META-INF/services
|
cc @royteeuwen this adds OSGi support for autoconfigure and declarative config |
|
@jack-berg nice! This seems to fix almost everything that I was missing in previous branch. The only thing debatable left is that io.opentelemetry.sdk.autoconfigure.spi* is still a mandatory import in exporter-common / exporter-otlp, so if you would want to set up opentelemetry only through the SDK, that's not possible yet. |
Ah yes that should be optional. I think that's an artifact of that module having an implementaiton dependency on the SPI module, instead of compileOnly. Will fix, and look for similar other cases. |
|
Super, thanks for the effort @jack-berg :). Any idea when this would typically make it into release? Then I can update my frameworks to the native versions and archive my osgi wrappers 😄? Sorry, edit: Archiving my OSGi wrappers would only work if also the opentelemetry-java-instrumentation and the semconv would be OSGi-enabled. Any plans to also make a PR there :)? |
…tation provider modules
…y-java into osgi-autoconfigure
I think those are whole different questions! Semconv seems easy enough since its just two packages dependent on opentelemetry-api. Instrumentation seems like a bigger story because it has many many packages, its own SPIs, and of course the javaagent which isn't meant to be consumed like a normal library. Also, it has different maintainers with different priorities. So new set of questions to answer. I recommend we open new issues in those respective repos and go from there. |
|
FYI, I opened open-telemetry/opentelemetry-java-instrumentation#18884, open-telemetry/semantic-conventions-java#494 to discuss and track. |
Followup to #7964, #8401
Resolves #768